Package the Nix CLI with Meson #11060
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ericson2314
force-pushed
the
meson-nix
branch
2 times, most recently
from
52383a8
to
40cf8a0
Compare
Co-Authored-By: Qyriad <[email protected]>
|
I am merging this because we would like the Mesonification to be done by the next release. |
edolstra
reviewed
Jul 11, 2024
| @echo >> [email protected] | ||
| @echo ')"' >> [email protected] | ||
| @mv [email protected] $@ | ||
| $(d)/profile.md: $(d)/profiles.md.gen.hh |
There was a problem hiding this comment.
@Ericson2314 This looks wrong? I assume this rule should be the other way around. (But also the rule should be superfluous because we have a pattern rule for this.)
There was a problem hiding this comment.
@edolstra I think it is correct note profile vs profiles (the s). One of them includes the other. It could be .md.gen.hh on both sides, however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Priorities and Process
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.