Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tarball fetcher: Fix handling of cached tarballs #11019

Merged

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Jul 3, 2024

Motivation

Fixes a regression introduced in 5a9e1c0 where downloading a cached file causes the error "Failed to open archive (Unrecognized archive format)".

Context

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

Fixes a regression introduced in
5a9e1c0 where downloading a cached
file causes the error "Failed to open archive (Unrecognized archive
format)".
@edolstra edolstra added backport 2.23-maintenance Automatically creates a PR against the branch bug regression Something doesn't work anymore and removed backport 2.23-maintenance Automatically creates a PR against the branch labels Jul 3, 2024
src/libutil/tarfile.cc Outdated Show resolved Hide resolved
Copy link
Member

@roberth roberth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge when documented.

@edolstra edolstra enabled auto-merge July 5, 2024 14:29
@edolstra edolstra merged commit 8f280d7 into NixOS:master Jul 5, 2024
11 checks passed
@edolstra edolstra deleted the fix-failed-to-open-archive branch July 5, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug regression Something doesn't work anymore
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants