Use MemorySourceAccessor in DummyStore so writes work
#10915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
store
edolstra
reviewed
Jun 17, 2024
Add `read-only` setting to `dummy://` store for back compat Co-Authored-By: HaeNoe <[email protected]> Co-authored-by: Eelco Dolstra <[email protected]>
Ericson2314
force-pushed
the
dummy-memory
branch
from
f5ea10f
to
48cfbec
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
This makes the dummy store a lot more useful. In particular, it opens the door to running complex integration-ish store tests entirely in memory as part of the units tests so we have a reference implementation to hold against other store implementations.
Context
This was originally made for #10874.
Add
read-onlysetting todummy://store for back compat/Priorities and Process
Add 馃憤 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.