feat: add user@address:port support

NixOS · Apr 25, 2020 · 356b8ba · 356b8ba
1 parent c9d0cf7
commit 356b8ba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 5 deletions.
diff --git a/src/libstore/ssh.cc b/src/libstore/ssh.cc
@@ -2,14 +2,18 @@
 
 namespace nix {
 
-SSHMaster::SSHMaster(const std::string & host, const std::string & keyFile, bool useMaster, bool compress, int logFD)
-    : host(host)
-    , fakeSSH(host == "localhost")
-    , keyFile(keyFile)
+SSHMaster::SSHMaster(const std::string & hostNport, const std::string & keyFile, bool useMaster, bool compress, int logFD)
+    : keyFile(keyFile)
     , useMaster(useMaster && !fakeSSH)
     , compress(compress)
     , logFD(logFD)
 {
+    auto res = tokenizeString<std::vector<string>>(hostNport, ":");
+    port = res.size() > 1 ? atoi(res[1].c_str()) : 0; // if we have a port, parse that
+    host = res[0];
+
+    fakeSSH = host == "localhost" && !port;
+
     if (host == "" || hasPrefix(host, "-"))
         throw Error("invalid SSH host name '%s'", host);
 }
@@ -22,6 +26,8 @@ void SSHMaster::addCommonSSHOpts(Strings & args)
         args.insert(args.end(), {"-i", keyFile});
     if (compress)
         args.push_back("-C");
+    if (port != 0)
+        args.insert(args.end(), {"-p", std::to_string(port)});
 }
 
 std::unique_ptr<SSHMaster::Connection> SSHMaster::startCommand(const std::string & command)

diff --git a/src/libstore/ssh.hh b/src/libstore/ssh.hh
@@ -9,12 +9,13 @@ class SSHMaster
 {
 private:
 
-    const std::string host;
+    std::string host;
     bool fakeSSH;
     const std::string keyFile;
     const bool useMaster;
     const bool compress;
     const int logFD;
+    int port;
 
     struct State
     {