Remove inputsFrom from shell
#1036
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`.shell` takes unusually long to evaluate because `.build` includes multiple nixpkgses. This solves that problem, at the cost of not being able to run `make html` at the shell. This may be acceptable, because `make html` produces an incomplete yet somewhat useful nix.dev. We would assume that most if not all contributors would run `devmode` in the shell and not `make html` because that has added convenience and produces the complete nix.dev. At the risk of heresy, I would mention that with a flake we'd have enjoyed evaluation cache. Co-authored-by: ruben <[email protected]> Co-authored-by: kurogeek <[email protected]> Co-authored-by: Shahar "Dawn" Or <[email protected]> Co-authored-by: warren2k <[email protected]>
|
I see it's failing so converting to draft. |
|
The problem was already addressed by #1035 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
.shelltakes unusually long to evaluate because.buildincludesmultiple nixpkgses. This solves that problem,
at the cost of not being able to run
make htmlat the shell.This may be acceptable, because
make htmlproduces an incompleteyet somewhat useful nix.dev.
We would assume that most if not all contributors would run
devmodein the shell and not
make htmlbecause that has added convenienceand produces the complete nix.dev.
At the risk of heresy, I would mention that with a flake we'd have
enjoyed evaluation cache.
Co-authored-by: ruben [email protected]
Co-authored-by: kurogeek [email protected]
Co-authored-by: Shahar "Dawn" Or [email protected]
Co-authored-by: warren2k [email protected]