Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve highlighter #54

Merged
merged 11 commits into from
Mar 13, 2023
Merged

Improve highlighter #54

merged 11 commits into from
Mar 13, 2023

Conversation

JojOatXGME
Copy link
Contributor

I am currently looking into improving the highlighter and maybe add some basic completions. I am still working on it, but whoever is interested can make some comments here.

Related issues:

@JojOatXGME
Copy link
Contributor Author

Somehow, the highlighter is currently not reliable, at least not in very large files. I also have not yet found a good solution to test the highlighter. The test-solution from the documentation only seems to work for higher levels of severity, like for inspections. So it looks like I have to put some more research into this topic as anticipated.

@JojOatXGME JojOatXGME marked this pull request as ready for review March 10, 2023 00:59
@JojOatXGME
Copy link
Contributor Author

JojOatXGME commented Mar 10, 2023

The highlighting is still not reliable for very large files, but I haven't found the reason for it. I expect it is a bug somewhere in IntelliJ, but not sure. Anyway, I think it is time, so I will merge the changes this week.

This PR contains the first feature which performs basic code analysis on top of the AST. There is the risk that this update has a significant performance impact, but at least it performed well in my tests using some large files from nixpkgs.

@JojOatXGME JojOatXGME self-assigned this Mar 10, 2023
@JojOatXGME JojOatXGME merged commit a9b80bc into master Mar 13, 2023
@JojOatXGME JojOatXGME deleted the highlighter branch March 13, 2023 19:27
@JojOatXGME JojOatXGME mentioned this pull request Mar 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant