Skip to content
This repository has been archived by the owner on Nov 25, 2024. It is now read-only.

Support multi-module projects #8

Merged
merged 1 commit into from Jul 19, 2016
Merged

Support multi-module projects #8

merged 1 commit into from Jul 19, 2016

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2016

  • Aggregate dependencies from all modules and output
    project-info.json only after last module.
  • Skip dependencies without backing repositories
    (to not break buildMaven in nixpkgs due to missing
    'authenticated' attribute).

@ghost
Copy link
Author

ghost commented Jul 19, 2016

This should address the open issues #4 and #5.

Not sure if skipping the dependencies that are only local is the right thing
to do here. It could also be fixed in build-maven.nix.

@shlevy
Copy link
Member

shlevy commented Jul 19, 2016

I'm pretty sure skipping dependencies is the wrong thing to do, the build might go through but the result won't have needed deps. One possibility is if a dep is already in the local cache to try to determine some other way if it needs authentication?

Why did you turn off the streaming output?

Can you break these up into separate PRs or at least separate commits? There's a lot to disentangle here.

@ghost
Copy link
Author

ghost commented Jul 19, 2016

I'll remove the skipping of the dependencies.
In what way does this turn off streaming output? The steps to gather the sets of dependencies
is very fast compared (few hundred milliseconds in the project I have here) to the actual
output phase and calls to handleDependency.

Combine the dependencies from each module
and output a single project-info.json.
@shlevy
Copy link
Member

shlevy commented Jul 19, 2016

Ah, never mind, misunderstood. So to clarify what's going on here, execute is called for each project?

@ghost
Copy link
Author

ghost commented Jul 19, 2016

Yes, execute gets called once for each module defined in the root pom.xml.

@shlevy shlevy merged commit dc2c5f7 into NixOS:master Jul 19, 2016
@shlevy
Copy link
Member

shlevy commented Jul 19, 2016

New release propagating now.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant