Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: prune common configuration #519

Merged
merged 9 commits into from
Dec 11, 2024
Merged

build: prune common configuration #519

merged 9 commits into from
Dec 11, 2024

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Dec 10, 2024

  • Remove hard dependency on coretemp
  • Remove graphics workaround for old environment at TU Delft
  • Update available system packages for better workability
  • Group options logically and sort them from low-level to high-level
  • Remove bespoke /tmp tmpfiles option, nixpkgs has its own with 10d cleanup
  • Remove builder specific config (KSM, build users, login limits)
  • Remove cron email config leftover, we don't use cron timers anymore

This is just the first commit. See individual commit messages for remaining changes.

@mweinelt mweinelt requested a review from a team as a code owner December 10, 2024 17:45
@mweinelt mweinelt requested a review from vcunat December 10, 2024 17:45
@mweinelt mweinelt force-pushed the build-cleanup branch 4 times, most recently from 7d479c7 to fcabedf Compare December 11, 2024 02:34
@Mic92
Copy link
Member

Mic92 commented Dec 11, 2024

@mweinelt since you seem to have done some terraform provider migration to opentofu, can you also add this to your pull request: #520 ?

boot.kernel.sysctl = {
# reboot on kernel panic
"kernel.panic" = 60;
"kernel.panic_on_oops" = 1;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my experience this is not advisable at all and causes random reboots once every day or two.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just refactored this, the infra has been running with this for years. And personally I cannot confirm such a behavior either.

build/common.nix Outdated Show resolved Hide resolved
- Remove hard dependency on coretemp
- Remove graphics workaround for old environment at TU Delft
- Update available system packages for better workability
- Group options logically and sort them from low-level to high-level
- Remove bespoke /tmpfiles option, nixpkgs has its own with 10d cleanup
- Remove builder specific config (KSM, build users, login limits)
- Remove cron email config leftover, we don't use cron timers anymore
- Merge options
- Clean up stale SSH hosts
- Update *.foundation.detsys.dev SSH CA
All services have been migrated to mimas.nixos.org, its successor.
@mweinelt mweinelt enabled auto-merge December 11, 2024 15:15
@mweinelt mweinelt merged commit 28532c2 into master Dec 11, 2024
3 checks passed
@mweinelt mweinelt deleted the build-cleanup branch December 11, 2024 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants