Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reproduce.tt: Use realpath for tmpDir to fix macOS compatibility #1424

Merged
merged 1 commit into from
Nov 26, 2024

Conversation

AsterisMono
Copy link
Member

@AsterisMono AsterisMono commented Nov 25, 2024

On macOS, $TMPDIR comes with a trailing slash:

bash-3.2$ echo $TMPDIR
/var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T/

This causes tmpDir to be /var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310 and breaks the reproduction script.

❯ curl https://hydra.nixos.org/build/277917310/reproduce | bash
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
100  4293  100  4293    0     0   4420      0 --:--:-- --:--:-- --:--:--  4416
storing inputs and results in /var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310...
running nix-build...
using the following invocation:
+ nix-build --arg nixpkgs '{ outPath = /var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310/nixpkgs/source; rev = "b2a0e3125e8b373ee2d6480ebd3b8f5c20080796"; shortRev = "b2a0e31"; revCount = 705472; }' -I nixpkgs=/var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310/nixpkgs/source --arg officialRelease false --arg supportedSystems '[ "x86_64-linux" "aarch64-linux" "x86_64-darwin" "aarch64-darwin" ]' --option extra-binary-caches https://hydra.nixos.org/ --option system x86_64-linux /var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310/nixpkgs/source/pkgs/top-level/release.nix -A ''
error: syntax error, unexpected PATH_END, expecting DOLLAR_CURLY
       at «string»:1:62:
            1| { outPath = /var/folders/_q/t4wwsxvs33j409tc1tp3t5mc0000gn/T//build-277917310/nixpkgs/source; rev = "b2a0e3125e8b373ee2d6480ebd3b8f5c20080796"; shortRev = "b2a0e31"; revCount = 705472; }
             |

@dasJ dasJ merged commit 3b16941 into NixOS:master Nov 26, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants