make nixos module hydra from this repository by default #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When people reach out to the git repository they probably want to use hydra from the same source. This also removes the need for an overlay with simpler and more performant direct use of the nixpkgs passed in. Before it was re-importing nixpkgs. test
|
cc @Mindavi for review |
Mindavi
approved these changes
Oct 19, 2024
|
Note I was trying to make fewer things depend on the flake before / not potentially mix Nixpkgs downstream by default. But this is fine. I realized one of the things I put in nixos-tests is not a NixOS test; that is moved out maybe that file doesn't need |
|
People that used the nixos module instead of the flake now have to explicitly have to set the hydra package. I believe this is less error-prone interface than assuming they imported the overlay correctly. |
Ericson2314
reviewed
Nov 14, 2024
Comment on lines
+70
to
+75
| hydra = nixpkgs.legacyPackages.${system}.callPackage ./package.nix { | ||
| inherit (nixpkgs.lib) fileset; | ||
| rawSrc = self; | ||
| nix = nix.packages.${system}.nix; | ||
| nix-perl-bindings = nix.hydraJobs.perlBindings.${system}; | ||
| }; |
There was a problem hiding this comment.
The duplicating of the overlay also tripped me up, forgot to add nix-eval-jobs in both places.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When people reach out to the git repository they probably want to use hydra from the same source.
This also removes the need for an overlay with simpler and more performant direct use of the nixpkgs passed in. Before it was re-importing nixpkgs.