Let tests themselves intentionally leak temp dir #1320
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default Yath will clean up temporary files, so the result is the same. But `--keep-dirs` can be passed to `yath test` telling Yath to *not* clean them up instead. This is very useful for debugging.
|
When building in a nix derivation er seine News to worry to clean up. It's building outside of that a thing? And if so, do we need to worry about quickly flooding people's disks? |
|
@SuperSandro2000 the title is a bit misleading --- the tests themselves no longer clean up, but the test harness does (unless one opts out), so even in |
|
Noise then this sounds like a no brainer, LGTM |
cole-h
reviewed
Dec 8, 2023
Co-authored-by: Cole Helbling <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default Yath will clean up temporary files, so the result is the same. But
--keep-dirscan be passed toyath testtelling Yath to not clean them up instead. This is very useful for debugging.