Cleanup deps #1312
Merged
Cleanup deps #1312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- `nativeBuildInputs` vs `buildInputs` - narrow down `with`s for clarity - use `autoreconfHook` not `bootstrap` script These sorts of changes have also been done in the Nix repo.
Comment on lines
+145
to
+146
| nativeBuildInputs = | ||
| with final.buildPackages; [ |
There was a problem hiding this comment.
Suggested change
| nativeBuildInputs = | |
| with final.buildPackages; [ | |
| nativeBuildInputs = with final.buildPackages; [ |
There was a problem hiding this comment.
I don't like the existing style either, but if I did that I would be better off moving way more things around?
There was a problem hiding this comment.
hmmm but that would also be a much bigger change and I didn't see the other lines in the diff 😉
There was a problem hiding this comment.
I meant I think would be better in a separate PR to run an auto-format, and in this one to do the minimal thing
Comment on lines
+156
to
+158
| buildInputs = | ||
| with final; [ | ||
| unzip |
There was a problem hiding this comment.
Suggested change
| buildInputs = | |
| with final; [ | |
| unzip | |
| buildInputs = with final; [ | |
| unzip |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nativeBuildInputsvsbuildInputsnarrow down
withs for clarityuse
autoreconfHooknotbootstrapscriptThese sorts of changes have also been done in the Nix repo.