Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gitea status in flakes #1232

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

DarkKirb
Copy link
Contributor

@DarkKirb DarkKirb commented Jul 1, 2022

Curently the GiteaStatus plugin only works for legacy inputs, as it attempts to read repository metadata from the jobsetevalinputs (which I don’t think can be set for flakes).

This PR adds support for many gitea instances by checkng whether the domain is hosting gitea. This is done by querying the /api/swagger endpoint, as that is a small static page that contains “Gitea” even when the instance has been renamed.

Gitea instances that are hosted in a subfolder are not supported.

Curently the GiteaStatus plugin only works for legacy inputs, as it
attempts to read repository metadata from the `jobsetevalinput`s (which
I don’t think can be set for flakes).

This Commit adds support for many gitea instances by checkng whether the
domain is hosting gitea. This is done by querying the /api/swagger
endpoint, as that is a small static page that contains “Gitea” even when
the instance has been renamed.

[Gitea instances that are hosted in a
subfolder](https://docs.gitea.io/en-us/reverse-proxies/#nginx-with-a-sub-path)
are not supported.
@Ma27
Copy link
Member

Ma27 commented Oct 7, 2022

Even though the UI prohibits it, it's perfectly possible to specify both a flake-ref and jobset inputs.
I changed this in #922. With that patch you can do both (and I actually use it for precisely your use-case: building flakes in Hydra and pushing the status to gitea, see for instance https://hydra.ist.nicht-so.sexy/eval/795#tabs-inputs).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants