Skip to content

Commit

Permalink
Add comment from GitHub about adding to store as code comment
Browse files Browse the repository at this point in the history
  • Loading branch information
Ericson2314 committed Dec 6, 2023
1 parent 3df8feb commit 11f8030
Showing 1 changed file with 13 additions and 0 deletions.
13 changes: 13 additions & 0 deletions src/hydra-queue-runner/build-remote.cc
Original file line number Diff line number Diff line change
Expand Up @@ -425,6 +425,19 @@ static void copyPathFromRemote(
const ValidPathInfo & info
)
{
// Why both stores? @thufschmitt says:
//
// > I think it's an easy (and terribly inefficient 😬) way of
// making sure that `localStore.queryRealisations` will succeed
// (which we IIRC we need later to get back some metadata about the
// path to put it in the db).
// >
// > To be honest, we shouldn't do that but instead carry the needed
// metadata in memory until the point where we need it (but that can
// come later once we're confident that this is at least correct)
//
// TODO make the above change to avoid copying excess data back and
// forth.
for (auto * store : {&destStore, &localStore}) {
/* Receive the NAR from the remote and add it to the
destination store. Meanwhile, extract all the info from the
Expand Down

0 comments on commit 11f8030

Please sign in to comment.