Rework release-script to use GitHub releases #23
+59
−12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of committing builds of the installer to the prerelease branch using a cronjob, create draft GitHub releases on workflow dispatch. The release includes the nix-installer.sh script to allow running `curl https://github.com/NixOS/experimental-nix-installer/releases/download/v0.27.0/nix-installer.sh | bash` Or to get the latest release: `curl https://github.com/NixOS/experimental-nix-installer/releases/latest/download/nix-installer.sh | bash` Alternatively, binaries for each system can be downloaded from the release directly. One downside of this approach is that the version number is hardcoded in nix-installer.sh, and we'll have to bump it every time we do a release. The release job will error if there's a rev mismatch between the flake built by Hydra and the rev the job is run from. This means we'll only be able to run the job off of main. For testing, a Hydra eval ID can be specified, which skips the rev check. This will create a draft release using the artifacts from that Hydra eval even if there is a revision and/or version mismatch.
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-installer-workgroup/21495/31 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of committing builds of the installer to the prerelease branch using a cronjob, create draft GitHub releases on workflow dispatch.
The release includes the nix-installer.sh script to allow running
curl https://github.com/NixOS/experimental-nix-installer/releases/download/v0.27.0/nix-installer.sh | bashOr to get the latest release:
curl https://github.com/NixOS/experimental-nix-installer/releases/latest/download/nix-installer.sh | bashAlternatively, binaries for each system can be downloaded from the release directly.
One downside of this approach is that the version number is hardcoded in nix-installer.sh, and we'll have to bump it every time we do a release.
The release job will error if there's a rev mismatch between the flake built by Hydra and the rev the job is run from. This means we'll only be able to run the job off of main.
For testing, a Hydra eval ID can be specified, which skips the rev check. This will create a draft release using the artifacts from that Hydra eval even if there is a revision and/or version mismatch.