Update dependencies #315
Open
Update dependencies #315
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
diegobernardes
force-pushed
the
update-dependencies
branch
2 times, most recently
from
9d4c165
to
40a69b7
Compare
elzbietaZ
reviewed
Jun 6, 2024
internal/service/worker.go
Outdated
| @@ -95,7 +95,7 @@ func (w *Worker) Process( | |||
| } | |||
|
|
|||
| storage := bytes.NewBuffer([]byte{}) | |||
| err = lazypdf.SaveToPNG(ctx, uint16(page), uint16(width), scale, bytes.NewBuffer(payload), storage) | |||
| err = lazypdf.SaveToPNG(ctx, uint16(page), uint16(width), scale, 96, bytes.NewBuffer(payload), storage) | |||
There was a problem hiding this comment.
I miss so much named arguments in Go 😞. 96 is the DPI we're using now to render the PDF.
There was a problem hiding this comment.
can we move it to value and put a comment near it why 96?
There was a problem hiding this comment.
or at least make it clear in the commit message why 96
diegobernardes
force-pushed
the
update-dependencies
branch
2 times, most recently
from
60f9fe8
to
c07a7d2
Compare
Update lazypdf dependecy and bump Go version to 1.22.4. Issue: CW-608
diegobernardes
force-pushed
the
update-dependencies
branch
from
c07a7d2
to
a81bd99
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update lazypdf dependecy and bump Go version to 1.22.4.
Issue: CW-608