Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statistics Customization 1 #3707

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

Navid200
Copy link
Collaborator

This allows you to choose which items you would like to see on the statistics distribution page.
After this PR, you will only be able to remove some of the existing items.
If this is approved, we already have an open PR for adding capture rate. I will work on that to add that to the menu and give credit to the person opening that PR.
Later, I would also like to add very high and very low.

Changing the pie chart to a bar chart as you requested will come later.

I chose using a simple menu so that after closing the menu, you will still be on the statistics page instead of going to the main screen.

I have avoided adding any strings so that we can make sure we are happy with English before any translation work starts.

So, why do we need this?
This is not a bug fix. I think it can be useful. The distribution page is already very cluttered and we have an open PR to add yet one more item to it. This will allow one to remove what they don't need to clean up the page as they wish.

Please let me know what you think.

@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 10, 2024

Before After
Screenshot_20241009-231358 Screenshot_20241030-231331

|

@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 10, 2024

The Include menu items:

Screenshot_20241030-231740

@jamorham
Copy link
Collaborator

What are the default set of statistics which will be visible?

Is this currently inside a Scrollview? If not would it be better if it were?

@Navid200 Navid200 marked this pull request as draft October 20, 2024 03:10
@Navid200 Navid200 marked this pull request as ready for review October 29, 2024 23:10
@Navid200 Navid200 marked this pull request as draft October 29, 2024 23:47
@Navid200
Copy link
Collaborator Author

StatsParams.mp4

@Navid200 Navid200 marked this pull request as ready for review October 31, 2024 03:42
@Navid200 Navid200 closed this Oct 31, 2024
@Navid200 Navid200 reopened this Oct 31, 2024
@Navid200
Copy link
Collaborator Author

Navid200 commented Oct 31, 2024

What are the default set of statistics which will be visible?

They will all be visible as they are now.
We can decide in 2 PRs after this if we want to change the defaults. But, for now, I wanted to make the changes minimal to make the review easier.

Is this currently inside a Scrollview? If not would it be better if it were?

Yes, the main window showing the parameters is already in a scrollview.
Screenshot 2024-10-31 080125

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants