Upload treatments to multiple Nightscout servers

[Navid200]

Fixes: #266

We have had an open issue (see above link) for 6 years where sensor start/stop or treatments are only uploaded to the first server if we have more than one.

This PR fixes that.
I have tested entering treatments and starting and stopping and deleting treatments. they all are reflected on both servers after this PR.

However, I must say that I am not closing the queue. I have commented it out.
I am sorry I am not sure the negative side effect of that if any!
So, please review this taking my inexperience into account.

[jamorham]

I haven't fully reviewed these code paths but this looks like it would create infinitely repeating uploads

[Navid200]

We have a main (outside) loop that goes over all URLs here:

xDrip/app/src/main/java/com/eveningoutpost/dexdrip/utilitymodels/NightscoutUploader.java

Line 467 in 6b152b0

for (String baseURI : baseURIs) {

Every time we go through this loop (every URL), this line is executed:

xDrip/app/src/main/java/com/eveningoutpost/dexdrip/utilitymodels/NightscoutUploader.java

Line 496 in 6b152b0

doRESTUploadTo(nightscoutService, hashedSecret, glucoseDataSets, meterRecords, calRecords);

That line uploads readings, calibrations and treatments. But, only for treatments, there is a loop created here:

xDrip/app/src/main/java/com/eveningoutpost/dexdrip/utilitymodels/NightscoutUploader.java

Line 769 in 6b152b0

for (UploaderQueue up : tups) {

Therefore, this loop is inside the first loop I pointed out.
In other words, for every URL, we have to go through this loop for uploading treatments.

But, there are several instances inside this internal loop that upon fail or success, the queue is completed like this as an example:

xDrip/app/src/main/java/com/eveningoutpost/dexdrip/utilitymodels/NightscoutUploader.java

Line 810 in 6b152b0

up.completed(THIS_QUEUE);

The problem is that when the time comes for the outside loop to increment to the next URL, this queue is not recreated.
That's why the treatments are only uploaded to the first URL.

I removed the queue terminations. When testing, I have not noticed an infinite upload.

I admit that I have not resolved this gracefully. But, I want this resolved so that we can close an issue that has been open for 6 years.
How can I proceed to do this right?

[Navid200]

I am going to open another PR with better comments and description.

[Navid200]

I have opened another PR to address the same issue. This time, I am closing (completing) the upload queue: #3630