Fixed an Error that came up with my Instance #1471
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… to halt, this just ignores it.
|
Sorry, I kinda missed this! I am a bit confused how you even got that far though. In theory this should throw if there is any event without a type: https://github.com/Nheko-Reborn/mtxclient/blob/master/include/mtx/events_impl.hpp#L282 I would prefer if mtxclient already filtered events like that out. If you can reproduce this, can you try fixing it there? |
deepbluev7
reviewed
Jun 5, 2023
| @@ -34,6 +34,7 @@ | |||
| #include "UserSettingsPage.h" | |||
| #include "Utils.h" | |||
| #include "encryption/Olm.h" | |||
| #include <typeinfo> | |||
There was a problem hiding this comment.
This include seems unnecessary?
|
I guess it is possible that this check now is incomplete: https://github.com/Nheko-Reborn/mtxclient/blob/master/include/mtx/events_impl.hpp#LL269C39-L269C39 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to use nheko on my personal matrix instance, I ran into an issue where some invalid event (I believe it was entirely empty) had been added at some point, and each time I tried to login with nheko rather than working as intended, it would give me the repeating error:
[db] [error] failed to save state after initial sync: mdb_put: MDB_BAD_VALSIZE: Unsupported size of key/DB name/data, or wrong DUPFIXED sizeon each initial sync. I was able to solve this issue by simply having nheko ignore the error with a try catch statement. I'm not certain if this is the best way to do it, but it fixes it for me and I haven't seen any errors after using it.