Input method height #1011
Input method height #1011
Conversation
|
Yep, those look fine to me, but does it actually work on the PP? |
|
It works now. But it may not work everywhere. Do you want to get someone with e.g. Phosh to test it or just push it and wait if someone complains? |
| Component.onCompleted: { | ||
| fullHeight = height | ||
| } | ||
| onHeightChanged: { | ||
| if(!Qt.inputMethod.visible) | ||
| fullHeight = height | ||
| } |
There was a problem hiding this comment.
Won't this break on phone rotations? :D
There was a problem hiding this comment.
are you saying that when rotating the phone with the keyboard up, fullHeight won't change? Or fullHeight will change when it shouldn't?
Disregarding the fact that Nheko is more or less unusable in landscape mode (at 200% scaling, with On-screen keyboard), the former is not an issue, because the keyboard is stowed on rotation. The latter does happen, but I think that's actually desirable.
There's also the Screen QML Type which provides a property desktopAvailableHeight and height. At least the latter will be persistent and could be used. But that would require us to somehow determine what kind of platform we're on, I imagine people on Desktop want their images to resize according to the window size (what about multiple screens?). Another settings toggle should be the last option if nothing else is deemed satisfactory :D
This time, uncontroversial changes only