Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue #68] - Add function get_exporter_contents #90

Merged
merged 6 commits into from
Sep 14, 2021

Conversation

kdh92417
Copy link
Contributor

@kdh92417 kdh92417 commented Aug 29, 2021

Description

  • Create a function that processes content data of exporters to send to clients
  • schedule content data to be cached periodically.

Details

Add function get_exporter_contents()
Add a scheduler job for content data caching of exporters.
Add caching settings for file caching from settings

  • Check if exporters' Iac, alert rule and grafana dashboard exits
  • Send contents list created from backend to frontend
  • Complete testing after communicating with the @Joylish

Feedback

  • Fixed function name : get_exp_contents -> get_exporter_contents

Thank you for the feedback from @bart2001, @BaeJi77

@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

we have some issue about this commit as below in the mobile view.
image

And, page rendering is little bit slow. so may the clock icon needed it when the page loading. @Joylish

Plese check this issue out :)

Thnak you!

@kdh92417
Copy link
Contributor Author

kdh92417 commented Sep 1, 2021

I'll check and revise it after discussing it with @Joylish

@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

Hi @kdh92417 Your code has some slow response as below. Please check this issue out. Thanks :)
image

@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

@kdh92417 you can test with this docker image - nexclipper/exporterhub-api:release-api0.3.4-p90 from hub.docker.com
Thanks :)

@kdh92417
Copy link
Contributor Author

kdh92417 commented Sep 1, 2021

Okay, I'll check the test server once again and improve the performance by creating an API that cashes the contents lists data.
Thanks :)

@kdh92417
Copy link
Contributor Author

kdh92417 commented Sep 5, 2021

While working on caching, I have a question about the caching server.

  • The api container fetches data from the caching server and the scheduler container tries to make the caching server scheduleable periodically.
  • At this time, I want to add a container that runs the cache server to run the service. I'm curious what you think. @ralfyang

@BaeJi77
Copy link
Contributor

BaeJi77 commented Sep 5, 2021

I don't know directly about this function get_exp_contents(). And what is meaning exp?

Could you rename title more readable?

@bart2001
Copy link
Contributor

bart2001 commented Sep 5, 2021

While working on caching, I have a question about the caching server.

  • The api container fetches data from the caching server and the scheduler container tries to make the caching server scheduleable periodically.
  • At this time, I want to add a container that runs the cache server to run the service. I'm curious what you think. @ralfyang

@kdh92417
how about using mariabDB as Database caching?

@kdh92417 kdh92417 changed the title [Issue #68] - Add function get_exp_contents from Exporterview [Issue #68] - Add function get_exporter_contents Sep 9, 2021
@kdh92417
Copy link
Contributor Author

Hi @ralfyang
I modified the code to cache the contents data of the exporters every 5 minutes, so please check it once.

@ralfyang
Copy link
Contributor

Okay! Thanks let me check :) @kdh92417

@ralfyang
Copy link
Contributor

The page has something wrong as below.. please check this issue out @kdh92417.

image

@kdh92417
Copy link
Contributor Author

I revised the Scheduler and ExporterView code and commited it again.
I'm sorry, but please check it again @ralfyang.

@ralfyang
Copy link
Contributor

Thanks @kdh92417 :)
Let me check and I'll let you know the result. :)

@ralfyang
Copy link
Contributor

ralfyang commented Sep 14, 2021

I just checked this code working normally! Thanks :) @kdh92417

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants