Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Issue NexClipper#68] - Add shortcut information for recognize the contents existed or not on the list #94

Closed
wants to merge 4 commits into from

Conversation

Joylish
Copy link
Collaborator

@Joylish Joylish commented Aug 30, 2021

Overview

image

Something to discuss

  • I don't know where to put the new mark in the header. So I commented out this part.
  • It was ambiguous to divide the criteria because each exporters has differnt types of contents.
    This issue will be resolved after talking with @kdh92417

…ntents existed or not on the list

Doubts while working
1. I don't know where to put the new mark in the header. So I commented out this part.

2. It was ambiguous to divide the criteria because each exporters has differnt types of contents.
This issue will be resolved after talking with @kdh92417
@ralfyang
Copy link
Contributor

Please remove the E character. it's no need anymore :)
Thanks @Joylish

…ents of card in the exporter list

What
- remove one of types which is 'E' meaning exporter. It doesn't need to present exporter because it already be exporter
- revive 'new' in header and re-arrange status of contents under the name
- css works for card
@Joylish
Copy link
Collaborator Author

Joylish commented Aug 31, 2021

Thanks for the comment of @ralfyang

Edited to reflect your comments

image

@Joylish Joylish self-assigned this Sep 1, 2021
@Joylish Joylish added the enhancement New feature or request label Sep 1, 2021
@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

Thanks @Joylish ! I just check this out in my dev env. :)

@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

when I test this commit in my dev. env. it's not working with the landing page screen as below
image

Sub-page working normally as below
image

Please check this issue out. Thanks :) @Joylish

@ralfyang
Copy link
Contributor

ralfyang commented Sep 1, 2021

I just attached screen capture for check the latency issue
image

@Joylish
Copy link
Collaborator Author

Joylish commented Sep 1, 2021

I just attached screen capture for check the latency issue

Thanks to comment, @ralfyang

I think the latency problem is related to getting data from the api server and forwarding it.

To make the contents shortcut of the exporter this time, when the server gives each exporter information, contents information is added to the existing information.

Let's talk him about the delay problem. @kdh92417

@Joylish
Copy link
Collaborator Author

Joylish commented Sep 1, 2021

when I test this commit in my dev. env. it's not working with the landing page screen as below

Sub-page working normally as below

Please check this issue out. Thanks :) @Joylish

thx comment to @ralfyang

Please check after running server of python~~
If not, please tell me!

@Joylish
Copy link
Collaborator Author

Joylish commented Sep 9, 2021

Dear @ralfyang ,
Now solve the problem you suggested🤣
check plz~~

After edited in mobile view

@ralfyang
Copy link
Contributor

@Joylish Thank you! let me check and merge this! :)

@ralfyang
Copy link
Contributor

When I checked this commit for test, the page is noting show up as below capture.

image

@Joylish
Copy link
Collaborator Author

Joylish commented Sep 29, 2021

When I checked this commit for test, the page is noting show up as below capture.

image

Did you run the django server? I think you didn't run server

@ralfyang
Copy link
Contributor

Now, we have a lot of updates. due to the code conflict issue, this PR will be close without Merge. @Joylish
Please open a new PR after the source code update. Thanks :)

@ralfyang ralfyang closed this Sep 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add an shortcut information for recognize the contents existed or not on the list
2 participants