encapsulate trial params #286
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of the idea I had to encapsulate the parameters being passed into the BaseExperiment class.
We could do something similar with options related to presenting the experiment window.
This change organizes the trial options so they will be grouped together separate from the other parameters.
It will reduce the number of arguments being passed into the BaseExperiment init method.
Any ideas on how to organize the trial option dataclass will be appreciated - it seems the BaseExperiment class and accompanying trial options are suited for 'Event Related' experiments. Some modifications may be needed to better support 'Block' and 'Continuous' experiments such as the resting state experiment @tmorshed had created.
The PR is not ready to merge, I haven't tested it yet - more here to start a conversation.