Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add resting state EEG experiments #255

Draft
wants to merge 3 commits into
base: develop
Choose a base branch
from
Draft

Conversation

tmorshed
Copy link
Collaborator

PR to make a new experiment class eegnb.experiments.resting_state which includes "resting"-type tasks.

Progress:

  • There is a class for rs experiments.

Issues:

  • The BaseExperiment class handles the iti and soa between stimuli such that an iteration of events is assigned to one block, and does the win.flip() between trials. This causes the third and later beeps to not come through correctly.

Solution: either

  • Fix the BaseClass such that parts of the iti/soa/block design are infer-able using added higher-level input.
  • OR, base it off of aob.py wherein we do not use a binomial distribution, but rather a repetitive 0,1,0,1 stimulus parameter.
  • Hotfix in the meantime: The rs.RestingState experiment overrides the load_stimulus() and present_stimulus() classes and even creates a custom run_ts() method to run the experiment. Will be reverted after the new implementation is brought forward.

@tmorshed tmorshed self-assigned this Dec 15, 2023
@JohnGriffiths
Copy link
Collaborator

@tmorshed what is the future of this PR? Is it close to completion? Were there some structural issues with it still?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants