add loggly support #64
Conversation
Codecov Report
@@ Coverage Diff @@
## master #64 +/- ##
==========================================
- Coverage 74.66% 74.02% -0.64%
==========================================
Files 11 11
Lines 371 385 +14
==========================================
+ Hits 277 285 +8
- Misses 94 100 +6
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Thanks for this PR
a couple of points
- It's better to keep this tool OS agnostic
- Add options to both
envand .watch config - as you mentioned in point 2 let's use a general JSON-format since both graylogformat, and logglyformat are the same I can see that repeating for other services.
- Solve merge conflicts
- ES-lint
Other than that it will be a good addition
| setLoggerLevel(logLevel); | ||
| setLogglyTransport(logglyAccessToken, logglySubDomain, logglyTag); |
There was a problem hiding this comment.
Can we set a conditional check and only setLogglyTransport when the output type is chosen as loggly. as it doesn't make sense to always set it up
| import { getCommandVars } from './command'; | ||
|
|
||
| require('winston-loggly-bulk'); |
There was a problem hiding this comment.
I understand that require is more natively by node but let's stay with the code and use import
| const loggerConsoleOptions = { | ||
| timestamp: false, | ||
| colorize: false, | ||
| formatter: options => `${options.message}`, | ||
| json: true, |
There was a problem hiding this comment.
What will happen if type of output chosen was terminal?
| transports: [ | ||
| new (winston.transports.Console)(loggerConsoleOptions), | ||
| ] }); | ||
| let logger; |
|
|
||
| export default (data, type = 'terminal') => { | ||
| switch (type) { | ||
| case 'terminal': | ||
| logger.log('info', terminalFormat(data)); | ||
| break; | ||
| case 'graylog': | ||
| logger.log('info', JSON.stringify(grayLogFromat(data.transaction, | ||
| data.decodedInputDataResult, data.decodedLogs))); | ||
| logger.log('info', grayLogFromat(data.transaction, |
There was a problem hiding this comment.
I agree with your point, let's make them both jsonFormat
add loggly support using npm "winston-loggly-bulk"
NOTES
JSON is send to Loggly using winston transport, console transport still log using stringify (now an option in constructor)
Feedback welcome!