Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial nimbus implementation #388

Open
wants to merge 13 commits into
base: develop
Choose a base branch
from
Open

Add initial nimbus implementation #388

wants to merge 13 commits into from

Conversation

stdevMac
Copy link
Member

Changes:

  • Add a initial nimbus implementation for consensus, validator and import and key exporter.

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing

  • Yes

In case you checked yes, did you write tests?

  • Yes

Should be run also a validator using our stack with nimbus

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 17.12329% with 121 lines in your changes missing coverage. Please review.

Project coverage is 86.26%. Comparing base (000cc79) to head (43de0af).

Files with missing lines Patch % Lines
cli/actions/importKeys.go 1.96% 98 Missing and 2 partials ⚠️
cli/actions/slashing.go 40.00% 14 Missing and 1 partial ⚠️
cli/importKeys.go 45.45% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #388      +/-   ##
===========================================
- Coverage    88.06%   86.26%   -1.81%     
===========================================
  Files           99       99              
  Lines         5673     5808     +135     
===========================================
+ Hits          4996     5010      +14     
- Misses         553      669     +116     
- Partials       124      129       +5     
Flag Coverage Δ
unittests 86.26% <17.12%> (-1.81%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants