Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Online Client versions #292

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

Conversation

cbermudez97
Copy link
Contributor

Changes:

  • Allow Sedge to load latest supported clients versions when online.
  • Add new flag to reuse jwt secret when regenerating a Sedge setup.

Types of changes

What types of changes does your code introduce?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No

@cbermudez97 cbermudez97 self-assigned this Jun 8, 2023
@cbermudez97 cbermudez97 requested review from AntiD2ta, stdevMac and adriantpaez and removed request for AntiD2ta June 8, 2023 20:34
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 45.51% and project coverage change: -2.68 ⚠️

Comparison is base (847e2b9) 86.69% compared to head (1714a0c) 84.02%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #292      +/-   ##
===========================================
- Coverage    86.69%   84.02%   -2.68%     
===========================================
  Files           78       82       +4     
  Lines         4578     4833     +255     
===========================================
+ Hits          3969     4061      +92     
- Misses         523      686     +163     
  Partials        86       86              
Flag Coverage Δ
unittests 84.02% <45.51%> (-2.68%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/actions/update_clients.go 0.00% <0.00%> (ø)
configs/images/online_images.go 0.00% <0.00%> (ø)
configs/images/utils.go 25.53% <25.53%> (ø)
cli/generate.go 89.33% <60.00%> (-1.21%) ⬇️
cli/actions/actions.go 81.81% <75.00%> (+6.81%) ⬆️
cli/actions/importKeys.go 95.75% <100.00%> (+0.27%) ⬆️
cli/cli.go 68.64% <100.00%> (+0.78%) ⬆️
cli/sub_gen.go 95.81% <100.00%> (+0.05%) ⬆️
configs/images/default_images.go 100.00% <100.00%> (ø)
configs/images/images.go 100.00% <100.00%> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants