Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nimbus as consensus client #223

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Add nimbus as consensus client #223

wants to merge 16 commits into from

Conversation

stdevMac
Copy link
Member

@stdevMac stdevMac commented Jan 24, 2023

Changes:

  • Add Nimbus as Consensus Client

Types of changes

  • New feature (non-breaking change which adds functionality)

Testing

Requires testing

  • Yes
  • No

@stdevMac stdevMac added the enhancement New feature or request label Jan 24, 2023
@stdevMac stdevMac self-assigned this Jan 24, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jan 24, 2023

Codecov Report

Base: 62.75% // Head: 62.76% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (65ef38c) compared to base (f02687d).
Patch coverage: 53.84% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #223      +/-   ##
===========================================
+ Coverage    62.75%   62.76%   +0.01%     
===========================================
  Files           66       66              
  Lines         4677     4684       +7     
===========================================
+ Hits          2935     2940       +5     
  Misses        1634     1634              
- Partials       108      110       +2     
Flag Coverage Δ
unittests 62.76% <53.84%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
cli/cli_utils.go 70.75% <45.45%> (-1.10%) ⬇️
internal/pkg/generate/generate_scripts.go 100.00% <100.00%> (ø)
internal/utils/version.go 79.66% <0.00%> (+1.69%) ⬆️
cli/root.go 81.08% <0.00%> (+5.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants