Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix package installation problems and refactor classes #17

Merged
merged 3 commits into from
Jun 11, 2024

Conversation

Angelina-C
Copy link
Collaborator

The package version 1.0.0 from PyPi could not be installed. This was due to the code not being organized in a package. The following was done to fix the issue:

  • Create a Python package adb_pywrapper (note the underscore, a dash will not work)
    
  • move adb-pywrapper.py to this package
    
  • move the contents of adb_init.py to the package init
    
  • improve the setup.py to find the package
    
  • refactor the contents of adb_pywrapper.py so the imports are clean
    
  • adjust the README to match the correct imports
    

@Angelina-C Angelina-C merged commit a77e1f4 into main Jun 11, 2024
3 checks passed
@Angelina-C Angelina-C deleted the 16-fix-package-installation-problems branch June 11, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix package installation problems
2 participants