Skip to content

Commit

Permalink
Merge pull request #203 from Netflix/feature/OPLAliasInputForMacro
Browse files Browse the repository at this point in the history
Fix issue with using cpl virtual track alias
  • Loading branch information
svenkatrav authored Aug 21, 2017
2 parents a0fdd39 + 7e7b4d6 commit fab4bbb
Showing 1 changed file with 5 additions and 3 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -316,8 +316,7 @@ private static Map<String, Handle> populateCPLVirtualTrackHandles(ApplicationCom
StringBuilder handleBuilder = new StringBuilder();
handleBuilder.append("cpl/virtual-tracks/" + virtualTrack.getTrackID());
Handle handleType = new VirtualTrackHandle(handleBuilder.toString(), virtualTrack);
handleMap.put(handleBuilder.toString(), handleType);
}
handleMap.put(handleBuilder.toString(), handleType); }
break;

case MainAudioSequence: {
Expand Down Expand Up @@ -410,10 +409,13 @@ private void populateMacroHandles(Map<String, Handle> handleMap) {
*/
for(String handle: this.aliasMap.values()) {
Handle handleType = handleMap.get(handle);
if (handleType == null && !handle.contains("/inputs/")) {
// Ignore input aliases as they are not needed for dependency resolution
// Ignore cpl/virtual track aliases too. All track IDs are not available for OPL and hence cannot validate.
if (handleType == null && !handle.contains("/inputs/") && !handle.startsWith("cpl/virtual-tracks/")) {
imfErrorLogger.addError(IMFErrorLogger.IMFErrors.ErrorCodes.IMF_OPL_ERROR, IMFErrorLogger.IMFErrors.ErrorLevels.NON_FATAL,
String.format("Invalid handle %s in alias", handle));
}

}
}

Expand Down

0 comments on commit fab4bbb

Please sign in to comment.