Yingjianw/JDK 17 Upgrade #620
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevie9868
force-pushed
the
yingjianw/integrateThriftClientWithFastService
branch
2 times, most recently
from
1e0534f
to
ee79858
Compare
use thrift with fast service additional fix add back polaris test
stevie9868
force-pushed
the
yingjianw/integrateThriftClientWithFastService
branch
from
ee79858
to
b1bea50
Compare
stevie9868
force-pushed
the
yingjianw/integrateThriftClientWithFastService
branch
from
4669819
to
221d279
Compare
stevie9868
changed the title
bryanck
reviewed
Nov 12, 2024
| @@ -24,9 +24,9 @@ | |||
| import lombok.EqualsAndHashCode; | |||
| import lombok.Getter; | |||
| import lombok.NonNull; | |||
| import org.checkerframework.checker.nullness.qual.Nullable; | |||
There was a problem hiding this comment.
I think we want javax.annotation.Nullable (jakarta when we move to SBN3)
bryanck
reviewed
Nov 12, 2024
| @@ -56,7 +56,7 @@ public class HiveConnectorFactory extends SpringConnectorFactory { | |||
| connectorContext.getConfiguration() | |||
| .getOrDefault(HiveConfigConstants.USE_EMBEDDED_METASTORE, "false") | |||
| ); | |||
| final boolean useFastHiveService = useLocalMetastore && Boolean.parseBoolean( | |||
| final boolean useFastHiveService = Boolean.parseBoolean( | |||
There was a problem hiding this comment.
Do we need this anymore? I feel we should remove the embedded HMS entirely given it won't work anymore on SBN3.
bryanck
approved these changes
Nov 13, 2024
insyncoss
reviewed
Nov 14, 2024
| @@ -19,7 +19,7 @@ | |||
|
|
|||
| import com.fasterxml.jackson.annotation.JsonCreator; | |||
| import com.fasterxml.jackson.annotation.JsonValue; | |||
| import com.google.common.base.Preconditions; | |||
| //import com.google.common.base.Preconditions; | |||
There was a problem hiding this comment.
Curious what is the issue with Preconditions on java 17?
https://guava.dev/releases/17.0/api/docs/index.html?com/google/common/base/Preconditions.html
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.