Fix for #1528, setup ObjectMapper configuration for DgsWebSocketAutoC… #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…etAutoConfig to mirror DgsWebMvcAutoConfiguration.
srinivasankavitha
requested changes
Aug 17, 2023
...e/src/main/kotlin/com/netflix/graphql/dgs/subscriptions/websockets/DgsWebSocketAutoConfig.kt
Show resolved
Hide resolved
...com/netflix/graphql/dgs/subscriptions/websockets/autoconfigure/DgsWebSocketAutoConfigTest.kt
Outdated
Show resolved
Hide resolved
…be created by the dgs starter auto config.
…tions' into use-dgsobjectmapper-for-subscriptions
|
You can fix lint failure by running |
srinivasankavitha
approved these changes
Aug 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix for #1528, setup ObjectMapper configuration for DgsWebSocketAutoConfig to mirror DgsWebMvcAutoConfiguration.
Pull request checklist
first
Pull Request type
Changes in this PR
Issue #1528
The ObjectMappers in
WebsocketGraphQLTransportWSProtocolHandlerandWebsocketGraphQLWSProtocolHandlerhave been refactored for constructor injection instead of having each class instantiate its own ObjectMapper in a companion object. This fixes an immediate problem we are having where our subscriptions fail with errors because the subscription ObjectMappers do not have JSR310 time module configured. In addition,DgsWebSocketAutoConfighas been configured to create a Qualified ObjectMapper named "dgsObjectMapper" if it has not already been created.My previous Kotlin and Gradle experience is limited, so I just followed the patterns for how ObjectMapper is used and configured in
DgsRestControllerandDgsWebMvcAutoConfiguration. This PR establishes uniform ObjectMapper usage for graphql requests and subscriptions.Alternatives considered
I could have added the JSR310 time module to the companion object ObjectMappers in
WebsocketGraphQLTransportWSProtocolHandlerandWebsocketGraphQLWSProtocolHandler. But then what happens the next time a change is needed to ObjectMapper configuration. It would have to be changed in many places instead of just updating the "dgsObjectMapper" config.