This repository has been archived by the owner on Jan 3, 2023. It is now read-only.
Sarkars/unify pooling translate functions #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| std::shared_ptr<ng::Node> ng_avgpool = | ||
| make_shared<ng::op::AvgPool>(ng_input, ng_kernel_shape, ng_strides, | ||
| ng_padding_below, ng_padding_above, false); | ||
| std::shared_ptr<ng::Node> ng_pool = |
There was a problem hiding this comment.
Question:
Does TF AvgPool considers padding in average calculation? Just want to confirm here.
There was a problem hiding this comment.
Avg pool has this extra param whose default value is false:
https://github.com/NervanaSystems/ngraph/blob/066037c25901478ac79ead90aa6da721ab27c0c3/src/ngraph/op/avg_pool.hpp#L51
Earlier we were explicitly passing the false value, but even without it, the default value is going to be false
avijit-nervana
force-pushed
the
sarkars/unify_pooling_translate_functions
branch
from
e696e3d to
7978347
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.