Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon Tab List #98

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Weapon Tab List #98

wants to merge 7 commits into from

Conversation

exababy
Copy link
Contributor

@exababy exababy commented Dec 13, 2023

No description provided.

@crashzk
Copy link
Contributor

crashzk commented Dec 14, 2023

Some suggestions for the look.

image
image

I believe it would be interesting, both the message when logged in and to log in centralized and the buttons below it centered as well

Weapon images card, a space from one square to another.

image
I believe it would also be interesting to have these categories as a button option too, all the same color as the one selected, or if we hover the mouse over it to change the color, or the same color but with a darker tone. Is everything also centralized? I don't know, I think it would be good too.

@crashzk
Copy link
Contributor

crashzk commented Dec 14, 2023

image
Another question would be the spelling of the word Knife in the plural it would be Knives.

This change is at your discretion, I've already caught many players complaining about this to me. Does it really change something, not for me, it would just be the wrong way of writing but everyone understands if they use Knifes too.

I believe that this entire menu can be left in the singular, for me it would be fine. (Knife, Pistol, Rifle, etc)

@rabi07
Copy link

rabi07 commented Dec 15, 2023

Can you fix auto reload the page after selecting any team, (its go back to main page )

@crashzk
Copy link
Contributor

crashzk commented Dec 15, 2023

image
Is it possible to implement so that when clicking on the photo or nickname it redirects to Steam?

image
image

Regarding the tab list, I noticed that when we select All, the top mouse has a different color, but the other options do not, even changing to Pistols as in the screenshot above does not change the color.

I don't know if it would be a bug or if it was done just like that.

@originalaidn
Copy link
Contributor

originalaidn commented Dec 16, 2023

image Is it possible to implement so that when clicking on the photo or nickname it redirects to Steam?

line 62 index.php:

	echo "<div class='bg-primary p-3'><div class='avatar-name'><a href='https://steamcommunity.com/profiles/{$steamprofile['steamid']}'><img src='{$steamprofile['avatarmedium']}'><h2 class='username mb-0'>{$steamprofile['personaname']}</h2></a></div><form action='' method='get'><button class='btn btn-secondary' name='logout' type='submit'>Logout</button></form></div>";

and need this one to style.css:

.avatar-name a img,
.avatar-name a h2 {
  display: inline-block;
}

@crashzk
Copy link
Contributor

crashzk commented Dec 17, 2023

Would it also be possible to change the design to choose the knife and its skin?

Leave something like this:
image
image
image
image

In other words, we choose the knife model first, and then the skins option for the knife opens.

@exababy
Copy link
Contributor Author

exababy commented Dec 18, 2023

I'm gonna put this on hold for now.

@exababy exababy marked this pull request as draft December 18, 2023 07:41
@crashzk
Copy link
Contributor

crashzk commented Jan 25, 2024

@exababy news about this PR, or are you still going to wait a little longer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants