Enforce con_enable 1 and multiple fixes for keybind handling

[nullsystem]

Description

• Enforce con_enable 1 to fix console toggle issue
• Instead always enforce the "legacy" toggleconsole, because internally it requires con_enable to be set anyway, although the legacy menu toggles this.
• Basically means the support for legacy menu on this is an unsupported thing anyway
• Write the command file on save
• Fix attempts to write empty keys
• Unbind duplicate key

Toolchain

• Linux GCC Distro Native Arch/GCC 14

Linked Issues

• fixes Cannot enable developer console using new menu. It can only be enabled using the legacy menu. #586

[Rainyan]

I'm having trouble saving the preference, so I can't really test the change. Using the legacy menu, I can save the "developer console" setting correctly however.

Example:

bind.webm

[nullsystem]

@Rainyan It seems like it failed because 'q' was also used for lean left. Guess that's also why the legacy menu discards the other bind since it seems the behavior for GetButtonCodeForBind is 1:1 and can't handle more.
I'll put in a "fix" to match the legacy menu's behavior of unbinding the other key.

[Rainyan]

@Rainyan It seems like it failed because 'q' was also used for lean left. Guess that's also why the legacy menu discards the other bind since it seems the behavior for GetButtonCodeForBind is 1:1 and can't handle more. I'll put in a "fix" to match the legacy menu's behavior of unbinding the other key.

That was the other thing, but my main problem was being unable to turn off developer mode in the new menu.

[nullsystem]

@Rainyan I was able to turn it off... but then I checked again and realised the main issue wasn't fixed anyway.
I think I'll just force the legacy option to be on at all times. It's going to be odd to try to deal with the two anyway...

[nullsystem]

@Rainyan I've changed the description + title to reflect the way the change of the fix is done now. Basically the game will try to enforce con_enable 1 when possible and won't be dealing with the situation of using both legacy and new settings since they both collides anyway.

[nullsystem]

I've also gone ahead and do the duplicate keybind unbinding enforcement also.

[Rainyan]

This seems to fix my previous inability to toggle the developer console setting in the new menu.

However I'm a bit unclear as to what the ` bind stuff in NeoToggleConsoleEnforce is achieving. It seems that typing: bind ` in the dev console instantly toggles the console off from under your feet while you're still typing, which feels a bit weird.

Also worth noting that the default backtick bind does not work for some keyboard layouts, for example for the nordic kb layout it's impossible to press the ` bind afaik, rendering such a bind useless for those users.

[nullsystem]

@Rainyan It's mostly to try to enforce that bind to route to the NeoToggleConsole function. I think this solution would be fine for now as a quickfix but fixing it for other layouts/trying to check console can be done as a separate PR.

[AdamTadeusz]

Lets open an issue and merge this in then

[nullsystem]

@Rainyan I've put in a rough issue for now so it's noted: #620