Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce con_enable 1 and multiple fixes for keybind handling #589

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Enforce con_enable 1 and multiple fixes for keybind handling #589

wants to merge 1 commit into from
+44 −25

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Sep 15, 2024 •
edited
Loading

Description

  • Enforce con_enable 1 to fix console toggle issue
  • Instead always enforce the "legacy" toggleconsole, because internally it requires con_enable to be set anyway, although the legacy menu toggles this.
  • Basically means the support for legacy menu on this is an unsupported thing anyway
  • Write the command file on save
  • Fix attempts to write empty keys
  • Unbind duplicate key

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

@nullsystem nullsystem added the bug Something isn't working label Sep 17, 2024
@nullsystem nullsystem requested a review from a team September 18, 2024 17:27
@nullsystem nullsystem added Minor release priority Pull request is a priority for the next minor release and removed Minor release priority Pull request is a priority for the next minor release labels Sep 18, 2024
@nullsystem nullsystem added this to the v8.1-prealpha milestone Sep 18, 2024
@Rainyan
Copy link
Collaborator

Rainyan commented Sep 18, 2024

I'm having trouble saving the preference, so I can't really test the change. Using the legacy menu, I can save the "developer console" setting correctly however.

Example:

bind.webm

@nullsystem
Copy link
Collaborator Author

nullsystem commented Sep 18, 2024 •
edited
Loading

@Rainyan It seems like it failed because 'q' was also used for lean left. Guess that's also why the legacy menu discards the other bind since it seems the behavior for GetButtonCodeForBind is 1:1 and can't handle more.
I'll put in a "fix" to match the legacy menu's behavior of unbinding the other key.

@Rainyan
Copy link
Collaborator

Rainyan commented Sep 18, 2024

@Rainyan It seems like it failed because 'q' was also used for lean left. Guess that's also why the legacy menu discards the other bind since it seems the behavior for GetButtonCodeForBind is 1:1 and can't handle more. I'll put in a "fix" to match the legacy menu's behavior of unbinding the other key.

That was the other thing, but my main problem was being unable to turn off developer mode in the new menu.

@nullsystem nullsystem marked this pull request as draft September 18, 2024 21:34
@nullsystem
Copy link
Collaborator Author

@Rainyan I was able to turn it off... but then I checked again and realised the main issue wasn't fixed anyway.
I think I'll just force the legacy option to be on at all times. It's going to be odd to try to deal with the two anyway...

@nullsystem nullsystem changed the title SendMainMenuCommand so neo_toggleconsole is not tied to toggleconsole DRAFT: Enforce toggleconsole to be on all times so it only handled by root menu Sep 18, 2024
@nullsystem nullsystem marked this pull request as ready for review September 18, 2024 23:03
@nullsystem nullsystem changed the title DRAFT: Enforce toggleconsole to be on all times so it only handled by root menu Enforce toggleconsole to be on all times so root overridden key handles it itself Sep 18, 2024
@nullsystem nullsystem changed the title Enforce toggleconsole to be on all times so root overridden key handles it itself Enforce con_enable 1 so root overridden key handles it itself Sep 18, 2024
@nullsystem
Copy link
Collaborator Author

@Rainyan I've changed the description + title to reflect the way the change of the fix is done now. Basically the game will try to enforce con_enable 1 when possible and won't be dealing with the situation of using both legacy and new settings since they both collides anyway.

@nullsystem
Enforce con_enable 1 to fix console toggle issue
d08756d 
* Instead always enforce the "legacy" toggleconsole, because internally
  it requires con_enable to be set anyway, although the legacy menu
  toggles this.
* Basically means the support for legacy menu on this is an unsupported
  thing anyway
* Write the command file on save
* Fix attempts to write empty keys
* Unbind duplicate key
* fixes NeotokyoRebuild#586
@nullsystem nullsystem changed the title Enforce con_enable 1 so root overridden key handles it itself Enforce con_enable 1 and multiple fixes for keybind handling Sep 18, 2024
@nullsystem
Copy link
Collaborator Author

I've also gone ahead and do the duplicate keybind unbinding enforcement also.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working Minor release priority Pull request is a priority for the next minor release
Projects
None yet
Milestone
v8.1-prealpha
Development

Successfully merging this pull request may close these issues.

Cannot enable developer console using new menu. It can only be enabled using the legacy menu.
2 participants
@nullsystem @Rainyan