Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch news/blog from website, use latest git tag for version #580

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

nullsystem
Copy link
Collaborator

@nullsystem nullsystem commented Sep 14, 2024

Description

  • NOTE TO REVIEWERS: Do git fetch [UPSTREAM BRANCH NAME] --tags + run cmake before testing this
  • Use git describe to generate tag from the latest v* tag
  • Fetch news/blog from the website itself
    • Rate limited to once per day
    • Checked via the file's modified date
    • Takes straight from news.txt which is actually a TSV file in path, date, title order
  • News/blog main menu section now interactable
    • The entries are now clickable and will open up in a browser
    • Maximum of 5 entries
  • There some stuff about 64-bit time_t on 32-bit executable but that isn't going to be enabled and just some TODO comments to give it a proper look later
  • Update CI to fetch tags
  • It does mean it'll require another build after the tag/release is set so it can capture the tag.

Toolchain

  • Linux GCC Distro Native Arch/GCC 14

Linked Issues

Screenshot

2024-09-17T232235_screen

@nullsystem nullsystem force-pushed the BuildInfoExtra branch 2 times, most recently from 7afe8ca to ddd03e7 Compare September 14, 2024 11:39
@nullsystem nullsystem marked this pull request as ready for review September 14, 2024 11:40
@AdamTadeusz
Copy link
Contributor

AdamTadeusz commented Sep 16, 2024

image
Is this branch really out of date or is the get latest tag not working too well? Also your v8 tag has the text prealpha in the name of the tag, so the words pre-alpha will display twice once this is merged in if its working correctly

@AdamTadeusz
Copy link
Contributor

news.txt should probably be gitignored

@nullsystem
Copy link
Collaborator Author

image
Is this branch really out of date or is the get latest tag not working too well? Also your v8 tag has the text prealpha in the name of the tag, so the words pre-alpha will display twice once this is merged in if its working correctly

You need to force fetch the tags itself.
This was done prior to the tag change, I think just leaving the tag in full and drop the separate "pre alpha" could do.

* Build now utilizes latest git tags starting with v
* Loads up news on startup, rate limited to one day
@nullsystem nullsystem added the New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers. label Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
New Changes for Reviewers New changes has been made. This label is mostly to notify reviewers.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants