-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move binary files to neoAssets #568
Move binary files to neoAssets #568
Conversation
Do we want to pin this to a static |
As this works right now you would have to do that anyway since the commit hash in the cmake file this repository has to be updated to use new assets in the asset repository. I probably am misunderstanding what you said though. |
So you're just suggesting we use git tags instead of git commit hashes to reference versions of the assets repository? These and even branch names can be used if I understand correctly, unless we use use the git_shallow parameter in which case only branch names can be used I think |
Never mind im retarded, you're suggesting we don't select the version of assets used. So yeah we could point to the master branch for example and add the git shallow tag and that would mean we don't need an extra pr here and it would be even quicker to fetch the git asset repository. The only question is would older versions of this repo break with newer assets. The only things that might break in the future are probably like materials, but also the stuff we are planning with navmeshes might for some reason not be compatible with older version of the repo I don't know [Edit] Since the binary assets that are currently in this repository are version controller it seems like a safe bet to continue that practice by grabbing a specific version of those assets once they're in a different repository, but again I think it's unlikely anything will break with newer assets |
Yeah, I meant we most likely want to use a tag that points to the most recent change (like Pinning dependencies by hash is nice for reproducability, but for convenience we probably don't need super strict control over the asset versioning for the assets in particular. At least not for dev builds. |
Ill mark this as ready for review once Masterkatze has time to mess around with copy_directory versus the install command |
LGTM. The use of If someone wants to use manually cloned neoAssets:
|
Description
Move all asssets to neoAssets.
Toolchain
Linked Issues