-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add GitHub Actions workflow #492
Conversation
couldn't "RelWithDebInfo" be renamed to just "Release"? |
libraries for both windows and linux seem to still come as |
That was unintended, thanks for noticing. |
7a442cd
to
f2b14d6
Compare
RelWithDebInfo seems more accurate, since that's what it is. |
if github actions are gonna be used as a source of getting the latest version of the game for playtesters, having it called "Release" rather than "RelWithDebInfo" seems to be easier to find, even if it's less accurate |
|
It's correct because I think there is a confusion possible because now these profiles are more suitable for CI rather than developer use. If we want to 1:1 match between profile name and presence/absence of debug info then I think I'll rework this a little, something like this:
I don't know if we need to add other CMake build types to profiles, if someone need RelWithDebInfo or MinSizeRel then it's still possible to build without profiles (the usual -S and -B). |
huh, I thought the presets are like the new, better way to do it replacing the default way. Atleast that's how it looks like, with there not being info on the previous way in the README.md doesn't "RelWithDebInfo" CI still have the release binaries separated from the debug information? which is why they're ~9mb in size in your actions. That's why I thought it would do the same if I used the "linux-release" preset. |
CI build uses |
I see, I'll try building with that rn. |
I think that playtesters should use the builds only from CI (with separate debug info). Developers can build whatever they want. |
I suppose. I guess it being called "release" and having debug info makes sense for developers, considering the differences between the two or something, yeah. |
Also skip install of separate debug info if it's not enabled
Some small improvements
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Description
BUILD_DATETIME
from version info to stop rebuilding if not necessary.install
calls (primarily used for GitHub Actions)