-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot enable developer console using new menu. It can only be enabled using the legacy menu. #586
Comments
…sole * The "toggleconsole" commands seemed to be tied to the keybinding, so therefore instead use SendMainMenuCommand's engine to execute the command without it being tied to the keybind. * Simply put, the legacy toggleconsole no longer needs to be on in order for neo_toggleconsole command to work. * fixes NeotokyoRebuild#586
@Muffin-Dono I've decided the "legacy" console bind will be enforced on startup and there won't be support for using both legacy and new settings at the same time as it won't work out. So essentially still the current behavior. |
* Instead always enforce the "legacy" toggleconsole, because internally it requires con_enable to be set anyway, although the legacy menu toggles this. * Basically means the support for legacy menu on this is an unsupported thing anyway * Write the command file on save * Fix attempts to write empty keys * fixes NeotokyoRebuild#586
The behavior now will technically still be the same, using legacy menu with this will still lead to that behavior. However, the game will now try to enforce the "legacy" console convar when possible so that it can use the NT's console convar + bind to determine itself to toggle instead. This is mostly because the commands toggleconsole and enableconsole requires that "legacy" setting to always be enabled in order to be usable in the first place. |
* Instead always enforce the "legacy" toggleconsole, because internally it requires con_enable to be set anyway, although the legacy menu toggles this. * Basically means the support for legacy menu on this is an unsupported thing anyway * Write the command file on save * Fix attempts to write empty keys * Unbind duplicate key * fixes NeotokyoRebuild#586
Build Info
20240914_b2291c5
Description
New menu can disable developer console mode, but if developer console is disabled in the legacy menu, it cannot be enabled by the new menu. The expected behaviour is that it should be overridden by the option in the new menu.
Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = disabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled
To Reproduce
Go to options -> keybinds -> legacy -> disable developer console mode
Go to options -> keybinds -> enable developer console mode
Expected behavior
Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = enabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled
Actual behavior
Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = disabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled
Operating System
Version/Distro
Windows 10
Machine's CPU
No response
Machine's GPU
No response
GPU's driver
No response
Build's compiler
No response
Additional context and Screenshots
No response
The text was updated successfully, but these errors were encountered: