Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot enable developer console using new menu. It can only be enabled using the legacy menu. #586

Closed
1 of 2 tasks
Muffin-Dono opened this issue Sep 14, 2024 · 2 comments · Fixed by #589
Closed
1 of 2 tasks
Assignees
Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub.
Milestone

Comments

@Muffin-Dono
Copy link

Build Info

20240914_b2291c5

Description

New menu can disable developer console mode, but if developer console is disabled in the legacy menu, it cannot be enabled by the new menu. The expected behaviour is that it should be overridden by the option in the new menu.

Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = disabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled

To Reproduce

Go to options -> keybinds -> legacy -> disable developer console mode
Go to options -> keybinds -> enable developer console mode

Expected behavior

Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = enabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled

Actual behavior

Developer console mode is:
Disabled in legacy and disabled in new menu = disabled
Disabled in legacy and enabled in new menu = disabled
Enabled in legacy and disabled in new menu = disabled
Enabled in legacy and enabled in new menu = enabled

Operating System

  • Windows
  • Linux

Version/Distro

Windows 10

Machine's CPU

No response

Machine's GPU

No response

GPU's driver

No response

Build's compiler

No response

Additional context and Screenshots

No response

@Muffin-Dono Muffin-Dono added the Bug Report Bug Reports made through the "Report Issue" interface in GitHub. label Sep 14, 2024
@nullsystem nullsystem self-assigned this Sep 15, 2024
nullsystem added a commit to nullsystem/neo that referenced this issue Sep 15, 2024
…sole

* The "toggleconsole" commands seemed to be tied to the keybinding, so
  therefore instead use SendMainMenuCommand's engine to execute the
  command without it being tied to the keybind.
* Simply put, the legacy toggleconsole no longer needs to be on in order
  for neo_toggleconsole command to work.
* fixes NeotokyoRebuild#586
@blaberry blaberry added this to the QoL milestone Sep 16, 2024
@nullsystem
Copy link
Collaborator

@Muffin-Dono I've decided the "legacy" console bind will be enforced on startup and there won't be support for using both legacy and new settings at the same time as it won't work out. So essentially still the current behavior.

nullsystem added a commit to nullsystem/neo that referenced this issue Sep 18, 2024
* Instead always enforce the "legacy" toggleconsole, because internally
  it requires con_enable to be set anyway, although the legacy menu
  toggles this.
* Basically means the support for legacy menu on this is an unsupported
  thing anyway
* Write the command file on save
* Fix attempts to write empty keys
* fixes NeotokyoRebuild#586
@nullsystem
Copy link
Collaborator

The behavior now will technically still be the same, using legacy menu with this will still lead to that behavior. However, the game will now try to enforce the "legacy" console convar when possible so that it can use the NT's console convar + bind to determine itself to toggle instead. This is mostly because the commands toggleconsole and enableconsole requires that "legacy" setting to always be enabled in order to be usable in the first place.

nullsystem added a commit to nullsystem/neo that referenced this issue Sep 18, 2024
* Instead always enforce the "legacy" toggleconsole, because internally
  it requires con_enable to be set anyway, although the legacy menu
  toggles this.
* Basically means the support for legacy menu on this is an unsupported
  thing anyway
* Write the command file on save
* Fix attempts to write empty keys
* Unbind duplicate key
* fixes NeotokyoRebuild#586
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Report Bug Reports made through the "Report Issue" interface in GitHub.
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants