Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: more generic is_trivial #1905

Merged
merged 2 commits into from
Nov 15, 2024
Merged

feat: more generic is_trivial #1905

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1d16795
feat: more generic `is_trivial`
thofma Nov 15, 2024
82022c2
Update src/Rings.jl
thofma Nov 15, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Rings.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ Test whether the ring $R$ is trivial. A ring is trivial if it consists
of a single element, or equivalently if its characteristic is 1. Such
rings are also called zero rings.
"""
is_trivial(F::NCRing) = characteristic(F) == 1
is_trivial(F::NCRing) = iszero(one(F))
is_trivial(F::Field) = false

@doc raw"""
Expand Down
Loading