Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Fix @alias test on nightly (#1612)" #1716

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lgoettgens
Copy link
Collaborator

Reverts #1612.

The underlying issue has been fixed in JuliaLang/julia#54499 and should be available in tomorrows nightly and 1.11.0-beta2.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.42%. Comparing base (6b230ed) to head (00bf708).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1716      +/-   ##
==========================================
+ Coverage   87.35%   87.42%   +0.06%     
==========================================
  Files         117      117              
  Lines       29824    30066     +242     
==========================================
+ Hits        26053    26284     +231     
- Misses       3771     3782      +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@thofma thofma closed this May 29, 2024
@thofma thofma reopened this May 29, 2024
@thofma
Copy link
Member

thofma commented May 29, 2024

Which tomorrow did you mean?

@lgoettgens
Copy link
Collaborator Author

The failure seems to have changed. I need to investigate further

@lgoettgens
Copy link
Collaborator Author

JuliaLang/julia#54499 is only semi fixing this, see JuliaLang/julia#54664

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants