Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ally Support #295

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

Add Ally Support #295

wants to merge 7 commits into from

Conversation

matthew55
Copy link
Collaborator

@matthew55 matthew55 commented Jul 24, 2024

** STILL A WIP **

What's been done

  • View holdings & account balances
  • Make transactions on all accounts (including during extended trading hours)

What needs done?

  • Cookie support to get rid of that pesky 2FA
  • Testing, testing, testing! Every situation imaginable before this is merged with main
  • Make this headless because if users mess with the window everything will break
  • Add note warning about risk of being banned for using Ally for RSA

If you can think of other things that need done, please let me know!

@matthew55 matthew55 marked this pull request as draft July 24, 2024 02:06
@ImNotOssy
Copy link
Contributor

Well for RSA, Ally is no longer allowing RSA only trades.

@matthew55
Copy link
Collaborator Author

matthew55 commented Jul 24, 2024

I guess we will be getting banned then. I will make sure to add a note saying that Ally bans accounts caught partaking in RSA

@NelsonDane
Copy link
Owner

Well for RSA, Ally is no longer allowing RSA only trades.

True, but Ally could be used for other non-rsa trades too, but a note would be good that bans could occur.

@gabehal
Copy link

gabehal commented Aug 21, 2024

It doesnt seem to handle 2fa on mine

@matthew55
Copy link
Collaborator Author

@gabehal Can you provide more details? Are there any errors in console? What does the window show when you don't run it in headless mode? When I update this will it fix it 🤷 I don't remember what all uncommitted changes I have done and maybe it is already fixed.

@Akagui
Copy link
Sponsor

Akagui commented Aug 23, 2024

I guess we will be getting banned then. I will make sure to add a note saying that Ally bans accounts caught partaking in RSA

You might be able to get away with a single account if you are doing other trading activity on the brokerage as well but if you do it on multiple accounts they will definitely come to collect your head.

@matthew55
Copy link
Collaborator Author

I guess we will be getting banned then. I will make sure to add a note saying that Ally bans accounts caught partaking in RSA

You might be able to get away with a single account if you are doing other trading activity on the brokerage as well but if you do it on multiple accounts they will definitely come to collect your head.

Yeah, I think I will keep on using this so that people have Ally if they want it, but after hearing how strict Ally is I agree that this is not recommended for RSA use.

(By.CSS_SELECTOR, code_btn_selector))
)
driver.find_element(by=By.CSS_SELECTOR, value=code_btn_selector).click()
if botObj is not None and loop is not None:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code does not enter into this if statement

@matthew55 matthew55 added enhancement New feature or request low-priority Probably won't be worked on anytime soon, but hopefully one day. labels Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request low-priority Probably won't be worked on anytime soon, but hopefully one day.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants