Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating CI workflow on Windows to use Natron pacman repo for deps. #936

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

It changes the CI workflow to use the Natron pacman repo like the "Build Installer" workflow does. This allows both workflows to benefit from fixes made in the Natron pacman repo.

  • Adding a step to the Windows workflow that downloads and sets up the Natron pacman repo. This is copied from the "Build Installer" workflow.
  • Removed dependencies from the "Install Windows system packages" that are installed when the mingw-w64-x86_64-natron-build-deps-qt5 package is installed.

Have you tested your changes (if applicable)? If so, how?

Yes. I've verified that the "Tests" action in the CI workflow builds again on Windows. (https://github.com/acolwell/Natron/actions/runs/7350002125)

Futher details of this pull request

This change is needed so that #935 also fixes the CI "Tests" workflow for Windows. All workflows should now pass.

- Adding a step to the Windows workflow that downloads and sets up
  the Natron pacman repo.

- Removed dependencies from the "Install Windows system packages"
  that are installed when the mingw-w64-x86_64-natron-build-deps-qt5
  package is installed.
@acolwell acolwell requested a review from devernay December 28, 2023 20:50
@acolwell
Copy link
Collaborator Author

Thanks for the quick review @rodlie

@acolwell acolwell merged commit af267b1 into NatronGitHub:RB-2.5 Dec 28, 2023
3 checks passed
@acolwell acolwell deleted the update-ci-action-to-use-natron-pacman-repo branch December 28, 2023 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants