Fix Windows build busters. #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Always include cstdint in GlobalDefines.h to avoid missing decl errors. - Change NATRON_BUILD_WORKSPACE to a shorter path to avoid path length errors that can occur during python file compilation. - Change logic in build-Windows-installer.sh related to mt.exe and the Qt Installer Framework so that these binaries could be retrieved from the Windows SDK and msys2 respectively.
acolwell
force-pushed
the
fix_missing_std_int_decls
branch
from
a5a93f4 to
cc3bea0
Compare
10 tasks
|
Friendly ping. The windows builds are broken without this fix and it appears the Linux has also started to fail with similar shiboken issues. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
This change fixes the Windows build. Recently msys2 updated pyside2/shiboken2 to version 5.15.11. This caused the build to start complaining about types like std::uint32_t & std::uint64_t being undefined when running shiboken2 to generate python stubs. This change makes the code always include cstdint since the typedefs derived from cstdint types are not guarded by #ifdefs. A few other minor changes were made to make the build process a little more robust.
This pull request contains the following changes:
Have you tested your changes (if applicable)? If so, how?
Yes. The "Build Installer" and "Tests" GitHub actions build on Windows again. (https://github.com/acolwell/Natron/actions/runs/6537802581)
(https://github.com/acolwell/Natron/actions/runs/6539421923)