Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'unknown warning option' warnings when building with Clang #1028

Merged

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Updates cmake build file to only specify gcc specific warnings when gcc is being used to build the code.

Have you tested your changes (if applicable)? If so, how?

Yes. I built the code locally with gcc and with clang. I verified that the clang builds no longer complain about unknown options and the options are still specified on gcc builds.

Copy link
Member

@YakoYakoYokuYoku YakoYakoYokuYoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would've added in the PR post body that it fixes #1027, LGTM regardless.

@acolwell acolwell merged commit e0d28bc into NatronGitHub:RB-2.6 Dec 23, 2024
3 checks passed
@acolwell acolwell deleted the fix_clang_unknown_warning_options branch December 23, 2024 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants