Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run build installer action for pull requests. #1026

Closed
wants to merge 1 commit into from

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Enables "Build Installer" workflow to run on pull requests so we can detect PRs that break the installers.

@acolwell acolwell force-pushed the build_installer_on_pr branch from bd1b1f1 to 395d982 Compare December 20, 2024 23:20
@acolwell acolwell force-pushed the build_installer_on_pr branch from 395d982 to 694169a Compare December 21, 2024 00:01
@acolwell
Copy link
Collaborator Author

This wasn't ready. I thought it would be simple, but since pull requests aren't a real branch the current checkout code for the installer script doesn't work cleanly. Closing for now.

@acolwell acolwell closed this Dec 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant