Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows installer build #1025

Conversation

acolwell
Copy link
Collaborator

Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:

PR Description

What type of PR is this? (Check one of the boxes below)

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Improvement (non-breaking change which does not add functionality nor fixes a bug but improves Natron in some way)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • My change requires a change to the documentation
    • I have updated the documentation accordingly

What does this pull request do?

Fixes build breakages caused by PR #1020

  • Fix include dirs
  • Change installer script to use new sourceCleanup script.

Have you tested your changes (if applicable)? If so, how?

Yes. Successfully built installer https://github.com/acolwell/Natron/actions/runs/12422959235 and it passes all its tests. I also downloaded the installer and manually verified it behaved as expected with a few test projects.

- Fixes build breakages caused by PR NatronGitHub#1020
@YakoYakoYokuYoku YakoYakoYokuYoku merged commit abe44f8 into NatronGitHub:RB-2.6 Dec 20, 2024
3 checks passed
@acolwell acolwell deleted the fix_windows_installer_after_qt6_changes branch December 20, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants