Fix Windows build #1017
Merged
Fix Windows build #1017
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add a dependency on mingw-w64-x86_64-pkg-config since the installer script depends on it. - Fix libraw package build by removing an export to a directory that does not exist. - Remove distutils from list of directories to copy in python zip since distutils was removed in python 3.12 - Add zipfile module to python zip since get-pip requires it now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for submitting a pull request! Please provide enough information so that others can review your pull request. Additionally, make sure you've done all of these things:
PR Description
What type of PR is this? (Check one of the boxes below)
What does this pull request do?
Various fixes to get the Windows build working again. The changes are simply responding to changes in the MSYS2 build environment and the update to python 3.12
Add a dependency on mingw-w64-x86_64-pkg-config since the installer script depends on it.
Fix libraw package build by removing an export to a directory that does not exist.
Remove distutils from list of directories to copy in python zip since distutils was removed in python 3.12
Add zipfile module to python zip since get-pip requires it now.
Have you tested your changes (if applicable)? If so, how?
Yes. Verified pacman repo builds again (https://github.com/acolwell/Natron/actions/runs/12072707931) and verified that the Windows installer builds (https://github.com/acolwell/Natron/actions/runs/12074140306). I did minor manual testing of the installer built to verify things were still working.