Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix DPO sequence packing + pipeline parallel #437

Merged
merged 1 commit into from
Dec 9, 2024
Merged

Conversation

ashors1
Copy link
Collaborator

@ashors1 ashors1 commented Dec 9, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ashors1 ashors1 requested a review from terrykong December 9, 2024 20:00
@ashors1 ashors1 changed the title [bug fix] fix DPO sequence packing + pipeline parallel [fix] fix DPO sequence packing + pipeline parallel Dec 9, 2024
@ashors1 ashors1 added the Run CICD Set + un-set to retrigger label Dec 9, 2024
@ashors1 ashors1 changed the title [fix] fix DPO sequence packing + pipeline parallel fix: fix DPO sequence packing + pipeline parallel Dec 9, 2024
@terrykong terrykong enabled auto-merge (squash) December 9, 2024 20:05
@terrykong terrykong merged commit 3791aad into dev Dec 9, 2024
22 of 25 checks passed
@terrykong terrykong deleted the ashors/pp-pack branch December 9, 2024 20:37
ashors1 added a commit that referenced this pull request Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants