Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add context parallel support for SFT #430

Merged
merged 14 commits into from
Dec 6, 2024
Merged

Conversation

ashors1
Copy link
Collaborator

@ashors1 ashors1 commented Dec 4, 2024

What does this PR do ?

Add a one line overview of what this PR aims to accomplish.

Changelog

  • Please update the CHANGELOG.md under next version with high level changes in this PR.

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this 

Before your PR is "Ready for review"

Pre checks:

Checklist when contributing a new algorithm

  • Does the trainer resume and restore model state all states?
  • Does the trainer support all parallelism techniques(PP, TP, DP)?
  • Does the trainer support max_steps=-1 and validation?
  • Does the trainer only call APIs defined in alignable_interface.py?
  • Does the trainer have proper logging?

Additional Information

  • Related to # (issue)

@ashors1 ashors1 changed the title feat: add context parallel support to SFT feat: add context parallel support for SFT Dec 4, 2024
@ashors1 ashors1 added the Run CICD Set + un-set to retrigger label Dec 4, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 4, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 4, 2024
@terrykong terrykong added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 5, 2024
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
Signed-off-by: ashors1 <[email protected]>
@github-actions github-actions bot added the CI label Dec 6, 2024
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 6, 2024
@ashors1 ashors1 requested a review from terrykong December 6, 2024 00:33
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 6, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 6, 2024
Signed-off-by: ashors1 <[email protected]>
@ashors1 ashors1 removed the Run CICD Set + un-set to retrigger label Dec 6, 2024
@ashors1 ashors1 added the Run CICD Set + un-set to retrigger label Dec 6, 2024
terrykong and others added 2 commits December 6, 2024 18:16
Signed-off-by: Terry Kong <[email protected]>
for more information, see https://pre-commit.ci

Signed-off-by: NeMo-Aligner CI <[email protected]>
@terrykong terrykong added Run CICD Set + un-set to retrigger and removed Run CICD Set + un-set to retrigger labels Dec 6, 2024
@terrykong terrykong enabled auto-merge (squash) December 6, 2024 18:23
@terrykong terrykong disabled auto-merge December 6, 2024 18:23
@terrykong terrykong merged commit 3604fc4 into dev Dec 6, 2024
19 checks passed
@terrykong terrykong deleted the ashors/cp-sft-dev branch December 6, 2024 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI Run CICD Set + un-set to retrigger
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants